fix: adjust circuit breaker benchmarks #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Crate versions that have been updated:
Runtime version has not been increased. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #622 +/- ##
==========================================
+ Coverage 64.63% 64.66% +0.03%
==========================================
Files 130 130
Lines 9450 9459 +9
==========================================
+ Hits 6108 6117 +9
Misses 3342 3342
☔ View full report in Codecov by Sentry. |
It looks like the weight was wrong. I checked other benchmarks/weights and 1 nanosecond ~= 1_000 weight. So the weight should be correct now. |
Roznovjak
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Processed TODOs to split up on_initialize benchmarking into trade and liquidity separately
NOTE: The bench weight result of
on_finalizechanged a lot, not sure where it comes from as it was benchmarked now on the reference machine.